fix: XS + SES snapshots are deterministic (test) #3781
Conversation
|
@kriskowal do me a favor and test this on a mac? |
There was a problem hiding this comment.
Excellent.
We should maybe add a note about when the new test will need to be updated. I think any change in SES will require updating the hashes, also any change in the xsnap.js initialization code.
Also, this test is a bit awkward here in packages/solo/ .. I think we put it here because the snapStore was hard to build from somewhere else, but now that packages/swing-store has been consolidated, is that still true? Can we move it to packages/SwingSet/ or packages/xsnap?
I think we can move it to I'd rather not add a dependency from |
It's not entirely clear how this got fixed, but it no longer fails. fixes #2776
... now that SwingSet includes @agoric/swing-store as a dependency.
dckc
force-pushed
the
2776-xsnap-ses-deterministic
branch
from
825c15b to
cbca7d4
Compare
It's not entirely clear how this got fixed, but it no longer fails.
fixes #2776